-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reset the NSUserNotication handle on dismiss #17796
Conversation
Release Notes Persisted
|
I have automatically backported this PR to "3-1-x", please check out #17820 |
I have automatically backported this PR to "4-1-x", please check out #17821 |
I have automatically backported this PR to "5-0-x", please check out #17822 |
@MarshallOfSound @codebytere Looks like this has caused a regression w.r.t. HTML notifications which crashes Electron on macOS when a notification comes in and is dismissed automatically by the system. We have not been able to consistently repro this yet on the We've tested with 3.1.6 and it doesn't crash, only happens with >=3.1.9 Here's a crash report if it helps understand the issue further.
|
@VishwasShashidhar thanks for letting us know! would you mind opening a new issue for tracking purposes and tagging me? |
Done @codebytere 👍 |
Fixes #17758
The destructor and
Dismiss
both attempt toremoveDeliveredNotification
which you can only do once.Notes: Fix crash when manually dismissing notifications before quit on macOS